Skip to content
This repository has been archived by the owner on Dec 28, 2023. It is now read-only.

Rebranding #17

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Rebranding #17

wants to merge 6 commits into from

Conversation

zloidemon
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #17 (5696b66) into master (d5031aa) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5696b66 differs from pull request most recent head 8ef46d2. Consider uploading reports for the commit 8ef46d2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          205       205           
=========================================
  Hits           205       205           
Impacted Files Coverage Δ
zyte_proxy_fetch/__init__.py 100.00% <100.00%> (ø)
zyte_proxy_fetch/logformatter.py 100.00% <100.00%> (ø)
zyte_proxy_fetch/middleware.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5031aa...8ef46d2. Read the comment docs.

@elacuesta
Copy link
Member

elacuesta commented Mar 24, 2021

Hey @zloidemon, thanks for handling this. I'd like to propose the following steps, to prevent existing projects from crashing because of the repo renaming:

  • Resolve this PR's conflicts
  • Rename this repository to scrapy-zyte-proxy-fetch
  • Make a copy of this repository under its current name (scrapy-crawlera-fetch)
  • Merge this PR
  • Add a deprecation warning to the new scrapy-crawlera-fetch, pointing to scrapy-zyte-proxy-fetch
  • Archive the new scrapy-crawlera-fetch

/cc @akshayphilar

@elacuesta
Copy link
Member

@zloidemon I resolved the conflicts, could you check the "allow edits from maintainers" box so I can push to your branch? Thanks!

@zloidemon
Copy link
Author

@zloidemon I resolved the conflicts, could you check the "allow edits from maintainers" box so I can push to your branch? Thanks!

I've already pushed fixes. Could you please review that diff?

@jpuigm
Copy link

jpuigm commented Jun 7, 2021

Rename this repository to scrapy-proxy-fetch

As per Developer Branding Guidelines, it should be renamed to scrapy-zyte-smartproxy-fetch. Am I right? @Gallaecio
cc @elacuesta @zloidemon

@akshayphilar
Copy link

@kmike are we building a separate Zyte Data API python client or do we reuse this?

@kmike
Copy link
Member

kmike commented Jun 7, 2021

@akshayphilar most likely, we'd need to build separate API client(s).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants