Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attributes dict accessor #107

Merged
merged 5 commits into from
Jun 8, 2018
Merged

Add attributes dict accessor #107

merged 5 commits into from
Jun 8, 2018

Commits on Jan 5, 2018

  1. add attrs() and attrs_all() methods

    @eliasdorneles
    eliasdorneles committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    6bd0054 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2018

  1. change attribute accessor approach to use .attrib instead 

    See discussion on: #107
    @eliasdorneles
    eliasdorneles committed Jan 21, 2018
    Configuration menu
    Copy the full SHA
    c39553b View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. add .attrib for SelectorList

    @eliasdorneles
    eliasdorneles committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    0eb7a45 View commit details
    Browse the repository at this point in the history

  2. add test for empty attributes cases

    @eliasdorneles
    eliasdorneles committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    ec6d3cb View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2018

  1. return dict copy on sel.attrib 

    This is done to prevent:

- changes in this object be reflected in a tree;
- keeping a reference to a tree and preventing response GC;
- isinstance(sel.attrib, dict) to be False

Thanks @kmike !
    @eliasdorneles
    eliasdorneles committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    ee042d1 View commit details
    Browse the repository at this point in the history