Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Im a bot option in onboarding #648

Merged
merged 24 commits into from
May 6, 2024

Conversation

TheYande
Copy link
Contributor

when a user selects this option in onboarding, they are automaticly kicked

this is ment to automaticly kick bots, becuase they usually pick every possible option

modules/joins.ts Outdated Show resolved Hide resolved
modules/joins.ts Outdated Show resolved Hide resolved
modules/joins.ts Outdated Show resolved Hide resolved
@cobaltt7
Copy link
Member

lint is failing bc you need to await

@TheYande
Copy link
Contributor Author

link can suck my ... ok sure

@cobaltt7
Copy link
Member

cobaltt7 commented Apr 16, 2024

it's import to always await - otherwise if it errors for whatever reason the error log will just say "hey uh this error occurred somewhere" instead of saying "...in the autoKick code at this line number". depending on how the code is set up, it could even crash the entire bot (it won't on scradd but still. i believe this is what caused the mod apps bot to be so unstable)

@TheYande
Copy link
Contributor Author

can you do the suggestinog thingy im lazy

modules/joins.ts Outdated Show resolved Hide resolved
@TheYande
Copy link
Contributor Author

ok i un locked out myself

modules/joins.ts Outdated Show resolved Hide resolved
@cobaltt7
Copy link
Member

cobaltt7 commented May 6, 2024

@TheYande Your code has a syntax error.
After you fix that, please fix the remaining lint error. This can be done automatically with npm run lint -- --fix. Finally, please gate this feature behind a flag - see #524 and 1a3c889.

@cobaltt7 cobaltt7 merged commit 644d994 into scratchaddons-community:main May 6, 2024
@TheYande TheYande deleted the ima-bot branch May 6, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants