Initial version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisandagain
commented
Dec 17, 2018
kchadha
reviewed
Dec 18, 2018
thisandagain
added
pr - good to merge
pr - needs review
pr - needs work
and removed
pr - good to merge
pr - needs work
labels
kchadha
reviewed
Dec 18, 2018
kchadha
reviewed
Dec 18, 2018
kchadha
reviewed
Dec 18, 2018
kchadha
reviewed
Dec 18, 2018
kchadha
reviewed
Dec 18, 2018
|
Thanks @kchadha. I addressed your comments with the exception of one (which I've opened an issue for on |
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Sets up the initial version of
scratch-analysiswhich replaces functionality from version1.0.2ofscratch-parserwhile also adding identical support for SB3 files.Context
This work is required to update the Scratch search crawler to support SB3 files prior to launch.
Test Coverage