Add validation for sprite2 and sprite3 files #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor schemas to support sprite2 and sprite3 files, while reusing rules in common with sb2 and sb3 files BREAKING CHANGE: Change to main API which now takes an additional boolean argument indicating whether a sprite or project is being validated
provide test coverage for sprite2 validation, and update sprite2_schema
thisandagain
previously requested changes
May 3, 2018
| * @param {Function} callback Returns error or project data | ||
| */ | ||
| module.exports = function (input, callback) { | ||
| module.exports = function (input, isSprite, callback) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -7,7 +7,7 @@ test('sb', function (t) { | |||
| var set = data.sb; | |||
| t.plan(set.length * 2); | |||
| for (var i in data.sb) { | |||
| parser(data.sb[i], function (err, res) { | |||
| parser(data.sb[i], false, function (err, res) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kchadha
dismissed
thisandagain’s stale review
Merging as per conversation in the comments/offline
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add support for .sprite2 and .sprite3 files (these aren't being created yet, so this PR does not include .sprite3 test fixtures). These changes include a refactor of the existing SB2 and SB3 validation such that:
Reason for Changes
scratchfoundation/scratch-gui#222
Test Coverage