-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI updates & parse script #50
base: master
Are you sure you want to change the base?
Conversation
Hey @alaaltoros can you add a description to this PR explaining what it is? |
PR related to issue #21 (Front-End UI for MVP) It includes the following:
I Will be updating it as soon as other parts are ready. P.S. The login/logout functionality requires google client id (check the README.md) and the upload button will output the parsed data in the console. |
Added report and file upload basic functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @alaaltoros, thanks for your contribution in building a UI for this project. I have done an initial review of this PR, but I cannot get it to work, meaning: I have installed the package deps, configured the client, and launched it, and it displays on the browser. The connection with Google OAuth seems fine, but after trying to log in, I get an error message Login failed
. I believe this may be due mostly to gaps in documentation. Kindly review the items I've highlighted in my review, and ping me with a mention when these are addressed, so that I can do a more in-depth review.
Thanks again!
UIcode/README.md
Outdated
touch .env.development | ||
|
||
# set API url i.e. http://localhost:4080 | ||
echo "REACT_APP_API_URL=http://localhost:4080" >> .env.development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused by this instruction to configure the API on port 4080, but the server is started below on port 3000. Can you please document this better, explaining the difference between the two ports if they are indeed different ports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the URL of the backend API, I added more description to this file.
Hello @lacabra, |
Added the Results page with formatted data. However, I could not test with a real response from findMatches endpoint of Enclave; I received no matches and could not upload report new results because of the CORS error. |
@alaaltoros I have tested your last changes and in general, it looks good. Regarding the issue that returns CORS error, I have done some tests and I see that the problem occurs when there are 2 consecutive calls to the Enclave endpoints. If I execute one only it works. I think the problem is related to the promise or await functions. |
@alaaltoros |
@alaaltoros can you resolve the conflicts? Also waiting for @cmalfesi CORS fixes in order to merge this. |
@assafmo conflicts resolved! |
Still seeing conflicts in |
PR related to issue #21 (Front-End UI for MVP)
It includes the following:
Basic UI
Login/logout with google
Location data parse script
I Will be updating it as soon as other parts are ready.
P.S. The login/logout functionality requires google client id (check the README.md) and the upload button will output the parsed data in the console.