Skip to content

Prepare release of v1.21.0 (polkadot-stable2512) #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Niederb wants to merge 13 commits into from
Closed

Prepare release of v1.21.0 (polkadot-stable2512) #881

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c63729a
Update version numbers of polkadot dependencies to crates.io using th…
Niederb Jan 12, 2026
385e69a
Configure RUSTFLAGS to support wasm and no-std builds
Niederb Jan 13, 2026
adeca51
Try with single quotes
Niederb Jan 13, 2026
8261797
Try escaping quotes
Niederb Jan 13, 2026
02fb41e
Set RUSTFLAGS directly in command
Niederb Jan 13, 2026
d084c5f
Remove approach for RUSTFLAGS that is not working
Niederb Jan 14, 2026
ce90995
Remove braces
Niederb Jan 14, 2026
5de82c8
Add documentation regarding RUSTFLAGS for wasm
Niederb Jan 14, 2026
9fe913d
Try different approach for setting RUSTFLAGS
Niederb Jan 14, 2026
59dd4d2
Try another approach
Niederb Jan 14, 2026
5282ebb
Set RUSTFLAGS in config.toml instead of inside the github action
Niederb Jan 15, 2026
9d57ae4
Incorporate review feedback
Niederb Jan 21, 2026
b921289
Fix formatting
Niederb Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ jobs:
#
# `test-no-std` is only meant to check if the `substrate-api-client` compiles to `no_std`, hence
# we omit clippy and test there.
cargo build --release -p test-no-std --features api-client,
cargo build --release -p test-no-std --features compose-macros,
cargo build --release -p test-no-std --features node-api,
cargo build --release -p test-no-std --features primitives,
RUSTFLAGS='--cfg substrate_runtime' cargo build --release -p test-no-std --features api-client,
RUSTFLAGS='--cfg substrate_runtime' cargo build --release -p test-no-std --features compose-macros,
RUSTFLAGS='--cfg substrate_runtime' cargo build --release -p test-no-std --features node-api,
RUSTFLAGS='--cfg substrate_runtime' cargo build --release -p test-no-std --features primitives,
Copy link
Collaborator

@clangenb clangenb Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to set the env at the step level here with:

      - name: ${{ matrix.check }}
        env: 
           RUSTFLAGS: '--cfg substrate_runtime'
        run: ${{ matrix.check }}

Copy link
Contributor Author

@Niederb Niederb Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found yet another approach that works with cargo directly by providing a config.toml.
I like this a bit more as it is more general, but so far I only managed to get it working for the wasm32 builds. For no-std I have not (yet) managed to find a solution that works with a config.toml 😞


# Check build of stand-alone features.
cargo check --no-default-features,
Expand All @@ -67,8 +67,8 @@ jobs:
cargo check --no-default-features --features std,

# Test for 32 bit and wasm32-unknown-unknown compatibility
cargo build -p substrate-api-client --target wasm32-unknown-unknown --no-default-features --features sync-api,
cargo build --release -p ac-examples-wasm --examples --target wasm32-unknown-unknown,
RUSTFLAGS='--cfg substrate_runtime' cargo build -p substrate-api-client --target wasm32-unknown-unknown --no-default-features --features sync-api,
RUSTFLAGS='--cfg substrate_runtime' cargo build --release -p ac-examples-wasm --examples --target wasm32-unknown-unknown,

# Test for 32 bit and wasm32-wasip1 compatibility
# As of PR https://github.com/scs/substrate-api-client/pull/858 this check fails
Expand Down
Loading
Loading