-
-
Notifications
You must be signed in to change notification settings - Fork 548
Snap update #4133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Snap update #4133
Conversation
Have you tested this at all? I am pretty sure the npm package doesn't support yarn out of the box? |
Yes I was able to build this on my ubuntu machine |
|
Any update? |
@sct I just set up a $50/mo sponsorship. This feature is a valuable one for how I run your software and if possible having it prioritized for review and acceptance and the snap updated would be appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Snapcraft configuration to use a newer base image and refactors build lifecycle commands.
- Bump Snap base from
core18
tocore22
and switch from thenodejs
plugin to thenpm
plugin - Replace
snapcraftctl
calls withcraftctl
defaults and update version/grade settings - Refine
override-build
steps (add comments, conditional file removal) and adjust workflowif
syntax
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
snap/snapcraft.yaml | Updated base, switched plugin to npm , unified lifecycle commands, refined build |
.github/workflows/snap.yaml | Changed if conditions to use ${{ }} expressions |
Comments suppressed due to low confidence (2)
snap/snapcraft.yaml:77
- The
npm
plugin does not install Yarn by default, soyarn build
may fail. Consider usingnpm run build
or adding an explicit Yarn installation step.
yarn build
snap/snapcraft.yaml:36
- [nitpick] Mixing
craftctl
andsnapcraftctl
can be confusing. It may be clearer to consistently use one CLI tool for all lifecycle steps.
craftctl default
Please, can we get some movement on this? I'd very much like to use Snap :) Thanks all. |
I really hope this can be merged, as I'm also not a fan of Docker. But if Snap is no longer supported, maintainers should update the installation instructions, as they currently read:
(And yes, in that case, please definitely provide migration instructions! Seems a lot easier to keep the snaffle updated, though.) |
Agreed - Lets get this merged, or lets go with an alternative path and update the |
Has anyone on the overseerr team looked at this PR? Any reason to not merge it? |
They're still trying to decide if they want Snap. I offered to do Flatpak if thats better |
any movement on this? |
@sct , @samwiseg0 , @OwsleyJr , @danshilm , @TheCatLady - Is the intention to still support snap as an installation mechanism for Linux? If so, why isn't this PR and multiple issues #4203 #4156 #4095 #4087 getting any attention? |
I migrated to Docker, which worked well with a little help from Google and reddit. |
It'd be really nice to update this so my setup supports requesting specials. I'd be willing to switch to Docker, but there's no clear official docs on that, and it's not exactly the easiest thing for my setup. Really any updates would be nice on this, either way. |
Despite a few attempts to discuss this on Discord, offering to help connect the development team with engineers at Canonical working on snaps, and donating to the project to help prioritize this I feel it won't likely happen which is quite disappointing. |
Maybe it's better to research and PR a change to the documentation detailing how to convert from a Snap install to a Docker install. |
I agree. If the preferred method going forward would be Docker, I don't mind the switch, but some documentation on performing the conversion to Docker would be highly appreciated. Perhaps a script that would assist with migrating from snap to Docker would be a better use of their time? I wouldn't mind donating to the project if that would buy a few devs a couple Hello Fresh boxes or a round of coffees for some folks. If I had time to tinker right now I'd be happy to pitch in my labor, but money is available and time isn't for me. Kindly, devs, I love Overseerr and it's just WORKED for years now. I want to use the updated version, but I'm currently locked into the outdated snap. Could you toss us homelabbers with a lack of time a bone if we throw a bit of money your way? |
Description
Fix for Snap