Skip to content

Conversation

Fyb3roptik
Copy link

@Fyb3roptik Fyb3roptik commented May 6, 2025

Description

Fix for Snap

@Fyb3roptik Fyb3roptik marked this pull request as ready for review May 6, 2025 21:49
@sct
Copy link
Owner

sct commented May 7, 2025

Have you tested this at all? I am pretty sure the npm package doesn't support yarn out of the box?

@Fyb3roptik
Copy link
Author

Yes I was able to build this on my ubuntu machine

@Fyb3roptik
Copy link
Author

Created snap package overseerr_1e844a09_amd64.snap

@Fyb3roptik
Copy link
Author

Any update?

@marcoceppi
Copy link

@sct I just set up a $50/mo sponsorship. This feature is a valuable one for how I run your software and if possible having it prioritized for review and acceptance and the snap updated would be appreciated.

@sct sct requested a review from Copilot June 18, 2025 01:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Snapcraft configuration to use a newer base image and refactors build lifecycle commands.

  • Bump Snap base from core18 to core22 and switch from the nodejs plugin to the npm plugin
  • Replace snapcraftctl calls with craftctl defaults and update version/grade settings
  • Refine override-build steps (add comments, conditional file removal) and adjust workflow if syntax

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
snap/snapcraft.yaml Updated base, switched plugin to npm, unified lifecycle commands, refined build
.github/workflows/snap.yaml Changed if conditions to use ${{ }} expressions
Comments suppressed due to low confidence (2)

snap/snapcraft.yaml:77

  • The npm plugin does not install Yarn by default, so yarn build may fail. Consider using npm run build or adding an explicit Yarn installation step.
      yarn build

snap/snapcraft.yaml:36

  • [nitpick] Mixing craftctl and snapcraftctl can be confusing. It may be clearer to consistently use one CLI tool for all lifecycle steps.
      craftctl default

@Ayymoss
Copy link

Ayymoss commented Jun 21, 2025

Please, can we get some movement on this? I'd very much like to use Snap :)

Thanks all.

@polarweasel
Copy link

I really hope this can be merged, as I'm also not a fan of Docker. But if Snap is no longer supported, maintainers should update the installation instructions, as they currently read:

The Overseerr snap is the only officially supported Linux install method aside from Docker."

(And yes, in that case, please definitely provide migration instructions! Seems a lot easier to keep the snaffle updated, though.)

@DevMan01
Copy link

I really hope this can be merged, as I'm also not a fan of Docker. But if Snap is no longer supported, maintainers should update the installation instructions, as they currently read:

The Overseerr snap is the only officially supported Linux install method aside from Docker."

(And yes, in that case, please definitely provide migration instructions! Seems a lot easier to keep the snaffle updated, though.)

Agreed - Lets get this merged, or lets go with an alternative path and update the README

@dmz006
Copy link

dmz006 commented Jul 16, 2025

Has anyone on the overseerr team looked at this PR? Any reason to not merge it?

@Fyb3roptik
Copy link
Author

They're still trying to decide if they want Snap. I offered to do Flatpak if thats better

@lainalex
Copy link

lainalex commented Aug 1, 2025

any movement on this?

@DevMan01
Copy link

DevMan01 commented Aug 3, 2025

@sct , @samwiseg0 , @OwsleyJr , @danshilm , @TheCatLady - Is the intention to still support snap as an installation mechanism for Linux? If so, why isn't this PR and multiple issues #4203 #4156 #4095 #4087 getting any attention?

@LetsGoDude
Copy link

I migrated to Docker, which worked well with a little help from Google and reddit.

@inform880
Copy link

It'd be really nice to update this so my setup supports requesting specials. I'd be willing to switch to Docker, but there's no clear official docs on that, and it's not exactly the easiest thing for my setup. Really any updates would be nice on this, either way.

@marcoceppi
Copy link

Despite a few attempts to discuss this on Discord, offering to help connect the development team with engineers at Canonical working on snaps, and donating to the project to help prioritize this I feel it won't likely happen which is quite disappointing.

@DevMan01
Copy link

Maybe it's better to research and PR a change to the documentation detailing how to convert from a Snap install to a Docker install.

@halberd388
Copy link

Maybe it's better to research and PR a change to the documentation detailing how to convert from a Snap install to a Docker install.

I agree. If the preferred method going forward would be Docker, I don't mind the switch, but some documentation on performing the conversion to Docker would be highly appreciated.

Perhaps a script that would assist with migrating from snap to Docker would be a better use of their time? I wouldn't mind donating to the project if that would buy a few devs a couple Hello Fresh boxes or a round of coffees for some folks.

If I had time to tinker right now I'd be happy to pitch in my labor, but money is available and time isn't for me.

Kindly, devs, I love Overseerr and it's just WORKED for years now. I want to use the updated version, but I'm currently locked into the outdated snap. Could you toss us homelabbers with a lack of time a bone if we throw a bit of money your way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.