Fix mobile-web-app-capable warning #4212
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysdovhan
requested review from
sct,
TheCatLady,
danshilm and
OwsleyJr
as code owners
| @@ -152,7 +152,7 @@ const PWAHeader = ({ applicationTitle = 'Overseerr' }: PWAHeaderProps) => { | |||
| href="/apple-splash-1136-640.jpg" | |||
| media="(device-width: 320px) and (device-height: 568px) and (-webkit-device-pixel-ratio: 2) and (orientation: landscape)" | |||
| /> | |||
| <meta name="apple-mobile-web-app-capable" content="yes" /> | |||
| <meta name="mobile-web-app-capable" content="yes" /> | |||
There was a problem hiding this comment.
The meta tag 'mobile-web-app-capable' is actually a non-standard tag. The correct approach is to keep 'apple-mobile-web-app-capable' for iOS Safari and add 'mobile-web-app-capable' separately for other browsers, or consider using the standard 'display' property in a web app manifest instead.
Suggested change
| <meta name="mobile-web-app-capable" content="yes" /> | |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<meta name="apple-mobile-web-app-capable" content="yes">is deprecated.<meta name="mobile-web-app-capable" content="yes">should be used instead.This causes a browser warning.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extract