Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue#359. Guard stcb->sctp_ep when setting the 'connecting' … #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Aug 30, 2019

Guard stcb->sctp_ep when setting the 'connecting' flag to prevent race conditions when two threads are binding and connecting to a socket.

…flag to prevent race conditions when two threads are binding and connecting to a socket.
@@ -8179,11 +8179,13 @@ sctpconn_connect(struct socket *so, struct sockaddr *addr)
/* Gak! no memory */
goto out_now;
}
if (stcb->sctp_ep->sctp_flags & SCTP_PCB_FLAGS_TCPTYPE) {
SCTP_INP_RLOCK(stcb->sctp_ep);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't aquire an inp lock here since you own already the stcb lock. This would result in a LOR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant