Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lwip support. #583

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ycyang1229
Copy link
Contributor

This is one rough version of lwip support, and it does not support ipv6. lwIP does not support sctp raw socket, so it only can support the feature of udp socket. The macro of ip header and udp header are added for the different naming between linux-based platform and lwip, but I noticed the similar data structure are also added for windows-based platform. Not sure which way is more suitable, so I added the macro first. thanks.

#580

@@ -79,6 +79,12 @@ option(sctp_sanitizer_memory "Compile with memory sanitizer" 0)

option(sctp_build_fuzzer "Compile in clang fuzzing mode" 0)

option(sctp_use_lwip "build with lwip" ON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include LWIP by default.

Copy link
Contributor Author

@ycyang1229 ycyang1229 May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will disable it when it is merged into it officially. Right now, it is one very rough version to show the idea.

@tuexen
Copy link
Member

tuexen commented May 3, 2021

OK, I see what the changes are about. I think getting support for this in will be a multi step approach. But I need to contemplate a bit how to do that first.
Is LWIP not supported on Windows?

@ycyang1229
Copy link
Contributor Author

OK, I see what the changes are about. I think getting support for this in will be a multi step approach. But I need to contemplate a bit how to do that first.
Is LWIP not supported on Windows?

I am not sure about it supports windows, since I usually run it on embedded devices. Let me search it in order to see it runs on windows or not. come back to you later.

@ycyang1229
Copy link
Contributor Author

It looks like lwip can not run on windows. Probably getting one embedded devices is an easier way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants