Fix getting log1p base #2546
Merged
Fix getting log1p base #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2546 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 104 104
Lines 11678 11678
=======================================
Hits 8425 8425
Misses 3253 3253
|
|
@ivirshup this is probably a good idea if scverse/anndata#999 is slated to go into some future anndata version. can we merge that other PR anyway? you didn’t respond there |
3 tasks
|
I added a test that fails on master |
flying-sheep
approved these changes
Jul 7, 2023
flying-sheep
pushed a commit
that referenced
this pull request
Jul 7, 2023
flying-sheep
added a commit
that referenced
this pull request
Jul 7, 2023
Co-authored-by: Simon P Shen <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error if the
log1pdict doesn't have abasekeyFixes #2497, fixes scverse/scanpy-tutorials#65, fixes #2181