Repository navigation
fix: resolve CellBrowser color paths for relative exports - #4495
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4495 +/- ##
=======================================
Coverage 85.13% 85.13%
=======================================
Files 138 138
Lines 12247 12247
=======================================
Hits 10427 10427
Misses 1820 1820
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4335.
CellBrowser stores the supplied export directory in categorical color-file references, then resolves those references relative to the configuration directory. A relative
data_dircan therefore produce a duplicated directory prefix and fail to find a color file that was just written.Pass an absolute data directory to both export and build, matching the existing working absolute-input behavior. Symlink and
..semantics, forwarded arguments and the wrapper's deprecation remain unchanged. The release note explains that existing configurations are preserved: affected references need correction or careful regeneration with custom settings saved. Absolute color references also need updating if the raw export directory moves.Validation
Previously generated broken configurations are not repaired automatically. CellBrowser's independent spatial-import and shell path-quoting defects are outside this change. Full repository tests, documentation build, native Windows and upstream CI were not run.
Post-submission verification
The release-note fragment has been renamed to 4495.fix.md. The targeted tests were independently rerun after the filename change and passed: 11 tests. Human review of the latest changes remains pending.
LLM usage
LLM or coding agent used
If one was used, I, a human, have reviewed, understood and tested every changed line
Closes sc.external.exporting.cellbrowser: cellbrowser_raw_data\sample_colors.tsv does not exist, skipping it An exception has occurred, use %tb to see the full traceback. #4335
Tests included: path forwarding and optional real CellBrowser integration.
Release notes not necessary because:
A release note is included as
4495.fix.md, matching the assigned PR number.