_set_color_source_vec and _render_points Refactor #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored _set_color_source_vec to remove catches for tables annotating point elements. get_values can now grab annotations for points from tables.
refactored _render points to be able to plot points and color by annotations from the element itself and from tables annotating points.
|
@dylanclam12 I think the codebase has changed quite a bit since you opened this draft - shall I close ? |
@timtreis yes you can close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored _set_color_source_vec to be compatible with the new get_values that can grab table annotating points.
Also refactored _render_points to be able to plot the new annotations.