Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformations are applied before rendering with datashader #378

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Sonja-Stockhaus
Copy link
Collaborator

Fixes #337

@Sonja-Stockhaus Sonja-Stockhaus linked an issue Oct 25, 2024 that may be closed by this pull request
@Sonja-Stockhaus
Copy link
Collaborator Author

Todo: similar for rendering of shapes with datashader

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (bc2db2c) to head (b3f5e45).

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/render.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   83.36%   83.38%   +0.02%     
==========================================
  Files           8        8              
  Lines        1653     1655       +2     
==========================================
+ Hits         1378     1380       +2     
  Misses        275      275              
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/render.py 90.30% <80.00%> (+0.05%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Points not transformed when method="datashader"
2 participants