-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft SpatialData.filter() #626
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 91.93% 91.59% -0.35%
==========================================
Files 44 44
Lines 6661 6688 +27
==========================================
+ Hits 6124 6126 +2
- Misses 537 562 +25
|
In the current state, it does not yet complete the issues that were aimed to resolve.
|
Thanks @aeisenbarth, after discussing with @melonora, we are going to first turn the code #627 into an internal function, merge, and then continue working on your PR. The idea is to provide a single entry point for filtering |
is there somewhere is the domentation that now describes how to filter a spatialdata object by cell IDs? this is valuable for several reasons, e.g. filtering cells removed by QC in analysis using other libraries |
(In reference to #620)
This PR imlements an more advanced filtering options than
subset
, allowing to create a new SpatialData object that contains only specific tables, layers, obs keys, var keys.Use cases
Closes #280
Closes #284
Closes #556