-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add sample site #134
Conversation
Sorry, for the huge delay. I tried to build it locally. Here are the results:
Some context:
I'm not sure how to resolve this issue. I tried installing/uninstalling some packages but nothing worked. |
I'll defer to @dgarcia360. |
Ok, it seems that I had to do a separate BTW, prerequisites mention that python 3.12 should work, but it does not seem to be the case. I needed to downgrade to python 3.10. The docs page is rendered as expected: There are some conflicts to be resolved. Also, I saw this PR, where we update sphinx scyllaDB theme to 1.8 for rust driver. I think this needs to be addressed here as well. Apart from that, LGTM. |
Thanks to @muzarski for reviewing. The theme is compatible with Python 3.12 starting from Sphinx Theme version 1.7.1. I'll update the theme to the latest version before merging. |
Sorry for the delay, docs theme updated to the latest version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Made a preview locally and it works as expected.
The failure in CI does not seem to depend on the changes introduced by this PR. I'll investigate it later.
Closes #125
Motivation
Adds a sample docs site to the project.
How to test
cd docs
make preview
Next steps after merging
Could you please enable the following option?
Thanks!