Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: point to rust-driver 64b4afcd #200

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

muzarski
Copy link
Collaborator

Currently, there are some open PRs that depend on changes recently introduced to rust-driver.
Let's bump the version of rust-driver dependency.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have implemented Rust unit tests for the features/changes introduced.
  • [ ] I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • [ ] I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

scylla-rust-wrapper/src/query_result.rs Outdated Show resolved Hide resolved
scylla-rust-wrapper/src/query_result.rs Outdated Show resolved Hide resolved
scylla-rust-wrapper/src/query_result.rs Outdated Show resolved Hide resolved
@muzarski
Copy link
Collaborator Author

v1.1: In rust-driver, we changed an error message emitted when statement id changes after repreparation. I adjusted the corresponding intergration test (PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare) to this new error message.

@muzarski muzarski self-assigned this Oct 28, 2024
@muzarski muzarski force-pushed the rust-driver-07553fee branch from 7189719 to 2fed762 Compare October 28, 2024 14:56
@muzarski muzarski changed the title cargo: point to rust-driver 07553fee cargo: point to rust-driver da199a18 Oct 28, 2024
@muzarski
Copy link
Collaborator Author

v2: Adjusted to scylladb/scylla-rust-driver@da199a1. Now there is no need to convert ColumnSpec<'query_result> to ColumnSpec<'static>

@muzarski muzarski force-pushed the rust-driver-07553fee branch from 2fed762 to 83ca870 Compare October 30, 2024 12:02
@muzarski muzarski changed the title cargo: point to rust-driver da199a18 cargo: point to rust-driver 64b4afcd Oct 30, 2024
@muzarski
Copy link
Collaborator Author

v2.1: Bumped again to scylladb/scylla-rust-driver@64b4afc

scylla-rust-wrapper/src/cass_types.rs Show resolved Hide resolved
scylla-rust-wrapper/src/cass_types.rs Show resolved Hide resolved
scylla-rust-wrapper/src/cass_types.rs Show resolved Hide resolved
scylla-rust-wrapper/src/exec_profile.rs Outdated Show resolved Hide resolved
@muzarski muzarski force-pushed the rust-driver-07553fee branch from 83ca870 to 0e3251d Compare October 30, 2024 14:49
@muzarski
Copy link
Collaborator Author

v2.2: replaced .clone() with Arc::clone() and rebased on master

@muzarski muzarski merged commit 39dd81e into scylladb:master Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants