Let retry policy to decide about non idempotent queries #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if |
dkropachev
requested changes
Dec 20, 2024
There was a problem hiding this comment.
On next PR let's do some heuristic from server error, take a look at parseErrorFrame
sylwiaszunejko
force-pushed
the
idempotent-flag-retry
branch
from
83d3210 to
63f2eea
Compare
dkropachev
reviewed
Dec 23, 2024
dkropachev
requested changes
Dec 23, 2024
…t might be not safe to retry it
sylwiaszunejko
force-pushed
the
idempotent-flag-retry
branch
from
63f2eea to
3f4d826
Compare
dkropachev
requested changes
Dec 23, 2024
policies.go
Outdated
| var executedErr *QueryError | ||
| if errors.As(err, &executedErr) { | ||
| err = executedErr.err | ||
| if executedErr.potentiallyExecuted && !executedErr.isIdempotent { |
There was a problem hiding this comment.
Don't use them directly, have getters please.
…dempotent queries
sylwiaszunejko
force-pushed
the
idempotent-flag-retry
branch
from
3f4d826 to
e8e5265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes: #326, #331