Skip to content

test: use NTS keyspace in PreparedStatementTest#944

Merged
dkropachev merged 1 commit into
scylla-3.xfrom
fix-preparedstatement-scylla-tablets
Jul 3, 2026
Merged

test: use NTS keyspace in PreparedStatementTest#944
dkropachev merged 1 commit into
scylla-3.xfrom
fix-preparedstatement-scylla-tablets

Conversation

@dkropachev

@dkropachev dkropachev commented Jul 2, 2026

Copy link
Copy Markdown

Scylla 2026.2.0 rejects SimpleStrategy when tablet replication is enabled. A few short integration tests still created keyspaces with SimpleStrategy, which causes the Scylla IT matrix to fail before the actual test assertions run.

This switches those test keyspaces to NetworkTopologyStrategy with datacenter1 RF=1, matching the 3.x test-suite cleanup already done for other Scylla integration tests.

Observed failures:

  • PreparedStatementTest.should_set_routing_key_on_case_sensitive_keyspace_and_table
  • MapperKeyspaceTest.beforeTestClass
  • UDTFieldMapperTest.udt_and_tables_with_ks_created_in_another_session_should_be_mapped
  • UDTFieldMapperTest.udt_and_tables_without_ks_created_in_another_session_should_be_mapped
  • InvalidConfigurationInQueryException: SimpleStrategy doesn't support tablet replication

Tested:

  • mvn -pl driver-core com.coveo:fmt-maven-plugin:check -Dverbose=false
  • mvn -pl driver-core -DskipTests test-compile -Dfmt.skip=true -Dclirr.skip=true -Danimal.sniffer.skip=true
  • mvn -pl driver-core,driver-mapping com.coveo:fmt-maven-plugin:check -Dverbose=false
  • mvn -pl driver-mapping -am -DskipTests test-compile -Dfmt.skip=true -Dclirr.skip=true -Danimal.sniffer.skip=true

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@dkropachev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 170e76ba-5568-43f8-a2c3-8835470ed031

📥 Commits

Reviewing files that changed from the base of the PR and between 44ee468 and 7b18eeb.

📒 Files selected for processing (3)
  • driver-core/src/test/java/com/datastax/driver/core/PreparedStatementTest.java
  • driver-mapping/src/test/java/com/datastax/driver/mapping/MapperKeyspaceTest.java
  • driver-mapping/src/test/java/com/datastax/driver/mapping/UDTFieldMapperTest.java
📝 Walkthrough

Walkthrough

This change modifies a single test in PreparedStatementTest.java. The CQL statement used to create the case-sensitive "Test" keyspace within the should_set_routing_key_on_case_sensitive_keyspace_and_table test now specifies NetworkTopologyStrategy with a datacenter1 setting, replacing the previous SimpleStrategy configuration with a replication_factor. No other test logic or public entities are affected.

Compact metadata:

  • Files changed: 1
  • Lines changed: +2/-2
  • Estimated review effort: Medium

Related issues: None specified

Related PRs: None specified

Suggested labels: test, low-risk

Suggested reviewers: None specified

Poem:
A keyspace once simple, now spans a wide land,
NetworkTopologyStrategy takes command.
No factors of replication, just datacenter1's grace,
The routing key still finds its rightful place. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change: switching PreparedStatementTest to use an NTS keyspace.
Description check ✅ Passed The description matches the change and explains the Scylla tablet-replication issue and test impact.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dkropachev dkropachev force-pushed the fix-preparedstatement-scylla-tablets branch from d0cfe22 to 7b18eeb Compare July 2, 2026 22:18
@dkropachev dkropachev merged commit 9d45182 into scylla-3.x Jul 3, 2026
12 checks passed
@dkropachev dkropachev deleted the fix-preparedstatement-scylla-tablets branch July 3, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant