Skip to content

test: wait for Scassandra pool removal after stop#945

Merged
dkropachev merged 1 commit into
scylladb:scylla-3.xfrom
dkropachev:dk/issue-387-wait-for-pool-removal
Jul 3, 2026
Merged

test: wait for Scassandra pool removal after stop#945
dkropachev merged 1 commit into
scylladb:scylla-3.xfrom
dkropachev:dk/issue-387-wait-for-pool-removal

Conversation

@dkropachev

Copy link
Copy Markdown

Summary

  • wait for ScassandraCluster.stop to observe session pool removal after a host is marked down
  • close the race where policy tests can issue queries while SessionManager.onDown is still closing the stopped host's pool

Fixes #387

Testing

  • git diff --check
  • mvn -pl driver-core -Dtest=RackAwareRoundRobinPolicyTest#should_only_use_remote_hosts_when_using_non_dc_local_cl,DCAwareRoundRobinPolicyTest#should_only_use_remote_hosts_when_using_non_dc_local_cl test

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dkropachev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fd891280-e0d7-4edb-957c-95577b849b59

📥 Commits

Reviewing files that changed from the base of the PR and between 9d45182 and cabda50.

📒 Files selected for processing (1)
  • driver-core/src/test/java/com/datastax/driver/core/ScassandraCluster.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dkropachev dkropachev merged commit 734a430 into scylladb:scylla-3.x Jul 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant