fix: use NetworkTopologyStrategy for keyspace creation to support ScyllaDB 2026.x#192
Merged
dkropachev merged 1 commit intoJun 30, 2026
Conversation
dkropachev
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #191.
Problem
ScyllaDbSinkConnector.javahardcodesSimpleStrategywhen creating the connector keyspace. ScyllaDB 2025.4+ enables tablets by default for all user keyspaces, and tablets requireNetworkTopologyStrategy—SimpleStrategyis outright rejected with:This causes the connector to fail at startup whenever
scylladb.keyspace.create.enabled=trueis used against ScyllaDB 2025.4+. It is also the root cause of the CI failures in PR #167.Fix
One-line change: replace
"SimpleStrategy"with"NetworkTopologyStrategy"in thewithReplicationOptionscall.NetworkTopologyStrategyacceptsreplication_factoras a shorthand (ScyllaDB docs) that auto-expands to all datacenters in the cluster. No DC name is required — the existingconfig.keyspaceReplicationFactorcontinues to be honoured as-is.Backwards Compatibility
IF NOT EXISTSclause means existing keyspaces are not affected.NetworkTopologyStrategywith thereplication_factorshorthand is supported by ScyllaDB (all versions) and Cassandra 4.0+.tablets = {'enabled': false}workaround.