CI: update cibuildwheel==2.16.2 so we can have python 3.12 wheels #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruch
force-pushed
the
wheel_for_python3.12
branch
from
b948967 to
b2eaa0e
Compare
cibuildwheel==2.16.2 supports building with python 3.12.0 release
* few import needed to be ajusted/ignored * need to update cython to latest version
since we want to support python 3.12, we need to remove
this pinning, cause those versions are casueing the cython
related unittets to fail:
```
ImportError while importing test module '/project/tests/unit/cython/test_bytesio.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/python/cp312-cp312/lib/python3.12/importlib/__init__.py:90: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
/project/tests/unit/cython/test_bytesio.py:16: in <module>
bytesio_testhelper = cyimport('tests.unit.cython.bytesio_testhelper')
/project/tests/unit/cython/utils.py:29: in cyimport
import pyximport
../venv/lib/python3.12/site-packages/pyximport/__init__.py:1: in <module>
from .pyximport import *
../venv/lib/python3.12/site-packages/pyximport/pyximport.py:51: in <module>
import imp
E ModuleNotFoundError: No module named 'imp'
```
eventlet is currently broken for python 3.12, so until we have a fixed version. we'll remove those tests from the build wheel action Ref: eventlet/eventlet#795
fruch
force-pushed
the
wheel_for_python3.12
branch
from
604b2cc to
a7bcd33
Compare
switch from `python setup.py sdist` to `python -m build --sdist` that's now the formal way to build, and not assume we have `distutil` installed on that system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cibuildwheel==2.16.2 supports building with python 3.12.0 release