Node Role - Forbid Scylla upgrade when not explicitly requested #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series introduces an early check to determine whether Scylla is already installed on the target system.
It provides a mechanism to prevent incorrectly (and dangerously) upgrading a system which may be already part of a running cluster.
In such scenarios, we now require
upgrade_version: True
, which delegates ALL upgrade logic to its relevant upgrade section in the role.To prevent a "chicken and egg" situation when we fail in the middle of a role execution AND after Scylla has been installed, we introduce the
skip_upgrade_check
option as a failsafe mechanism, which - obviously - defaults to false.Tests ran:
skip_upgrade_check: True
option, which allows us to get through and proceed with the installation/configuration processskip_upgrade_check: True
option, we see a failure complaining that Scylla is already installed.upgrade_version: True
&&upgrade_major: False
options, upgrade completes.Fixes #132