ansible-scylla-node: Use Scylla API for getting existent tokens instead of nodetool ring #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorribeiroduarte
force-pushed
the
improve_tokens_generation
branch
2 times, most recently
from
30289f5 to
7e590b6
Compare
vladzcloudius
requested changes
Dec 6, 2023
| copy: | ||
| content: "" | ||
| dest: /tmp/tokens_file | ||
| delegate_to: localhost |
There was a problem hiding this comment.
This won't work well when multiple concurrent instances of the job would be running.
Generate a temp file instead, please.
| dest: /tmp/tokens_file | ||
| delegate_to: localhost | ||
|
|
||
| - name: Get existent tokens |
There was a problem hiding this comment.
spelling: s/existent/existing/
| uri: | ||
| url: "http://{{ scylla_api_address }}:{{ scylla_api_port }}/storage_service/tokens/{{ item }}" | ||
| method: GET | ||
| register: _existent_tokens |
igorribeiroduarte
force-pushed
the
improve_tokens_generation
branch
2 times, most recently
from
1a4ce9c to
f91ad63
Compare
…during tokens generation This patch changes the role to stop validating that all nodes are in UN state during tokens generation, since the nodes don't have to be up in order for us to be able to retrieve existing tokens and generate the new ones.
…ad of nodetool ring Currently we're using nodetool ring to get the current tokens and iterating over its output in order to create an ansible fact with all the tokens. This might be a problem when using ansible verbose mode since nodetool ring prints one token per line and every time we append a value to the ansible fact the whole fact will be printed resulting in a very big number of lines printed, specially for big clusters. This patch fixes this problem by using the API to get the current tokens and by writing them to a file instead of to an ansible fact.
igorribeiroduarte
force-pushed
the
improve_tokens_generation
branch
from
f91ad63 to
986eb28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.