Skip to content

ansible-scylla-node: Enforces the installation of each APT key set #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

ebenzecri
Copy link
Contributor

Before this patch, if a key with a specific ID already installed was updated (because it was expired, for example), the key won't be locally updated causing and APT failure.

This patch ensures the usage of the latest apt key available.

Copy link
Collaborator

@vladzcloudius vladzcloudius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, file a GH issue describing the issue that this PR is fixing. Please, make sure to provide steps to reproduce.

Also note that CI, has failed too.

@vladzcloudius
Copy link
Collaborator

vladzcloudius commented Jan 24, 2024

Please, file a GH issue describing the issue that this PR is fixing. Please, make sure to provide steps to reproduce.

Also note that CI, has failed too.

@ebenzecri any progress with fixing the CI? You are using a gpg executable that is not installed in the Molecule docker image - hence the failure.

TASK [ansible-scylla-node : Remove an apt key by id previously added] **********
  failed: [node1] (item=d0a112e067426ab2) => {"ansible_loop_var": "item", "changed": false, "item": "d0a112e067426ab2", "msg": "Failed to find required executable \"gpg\" in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin"}
  failed: [node3] (item=d0a112e067426ab2) => {"ansible_loop_var": "item", "changed": false, "item": "d0a112e067426ab2", "msg": "Failed to find required executable \"gpg\" in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin"}
  failed: [node2] (item=d0a112e067426ab2) => {"ansible_loop_var": "item", "changed": false, "item": "d0a112e067426ab2", "msg": "Failed to find required executable \"gpg\" in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin"}
  failed: [node1] (item=5e08fbd8b5d6ec9c) => {"ansible_loop_var": "item", "changed": false, "item": "5e08fbd8b5d6ec9c", "msg": "Failed to find required executable \"gpg\" in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin"}
  failed: [node3] (item=5e08fbd8b5d6ec9c) => {"ansible_loop_var": "item", "changed": false, "item": "5e08fbd8b5d6ec9c", "msg": "Failed to find required executable \"gpg\" in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin"}
  failed: [node2] (item=5e08fbd8b5d6ec9c) => {"ansible_loop_var": "item", "changed": false, "item": "5e08fbd8b5d6ec9c", "msg": "Failed to find required executable \"gpg\" in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin"}

Before this patch, if a key with a specific ID already installed was updated (because it was expired, for example), the key won't be locally updated causing and APT failure.

This patch removes the key and install it, enforcing using the latest one available.

Fixes: scylladb#329

Signed-off-by: Eduardo Benzecri <[email protected]>
@vladzcloudius vladzcloudius merged commit 84ab7b9 into scylladb:master Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants