ansible-scylla-node: auto-detect NVMe: only use non-mounted disks. #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vreniers
force-pushed
the
auto_detect_nvme_fix
branch
from
eca0278 to
a9d2694
Compare
vreniers
changed the title
vreniers
force-pushed
the
auto_detect_nvme_fix
branch
from
a9d2694 to
ae5f053
Compare
vreniers
changed the title
igorribeiroduarte
previously approved these changes
Oct 23, 2024
misbehaves on md0 with multiple nvmes |
vreniers
force-pushed
the
auto_detect_nvme_fix
branch
from
ae5f053 to
c86cfd5
Compare
vreniers
changed the title
tarzanek
reviewed
Nov 5, 2024
| nvme list | awk '{print $1}' | tail -n +3 | ||
| for nvme_disk in $(lsblk -oNAME -nd | grep nvme) | ||
| do | ||
| { echo -n "/dev/$nvme_disk "; lsblk "/dev/$nvme_disk" -o MOUNTPOINT | grep / | wc -l; } | awk '{if ($2=="0") print $1}' |
There was a problem hiding this comment.
lsblk -n ?
to avoid printing header ?
NVMe disks should only be selected that are not in use, which should be the case when they are not mounted. Fixes scylladb#407 Signed-off-by: Vincent Reniers <[email protected]>
vreniers
force-pushed
the
auto_detect_nvme_fix
branch
from
c86cfd5 to
7debd91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVMe disks should only be selected that are not in use, which should be the case when they are not mounted.
Fixes #407