Skip to content

Commit

Permalink
fix(CDC_OPTIONS): Use boolean value for cdc preimage option
Browse files Browse the repository at this point in the history
CDC_SETTINGS_NAMES_VALUES['preimage'] uses string values "true" "false"
instead of bool True False. This cause assertion error if it was changed

```
AssertionError: CDC extension settings are differs.
Current: {'delta': 'full', 'enabled': True, 'preimage': True, 'postimage': True, 'ttl': '1800'}
expected: {'delta': 'full', 'enabled': True, 'preimage': 'true', 'postimage': True, 'ttl': '1800'}
```
  • Loading branch information
aleksbykov authored and fruch committed Jun 24, 2024
1 parent 5a9c603 commit 1350655
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdcm/utils/cdc/options.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
CDC_SETTINGS_NAMES_VALUES = {
"enabled": [True, False],
"delta": ["full", "keys"],
"preimage": ["full", "true", "false"],
"preimage": ["full", True, False],
"postimage": [True, False],
"ttl": "86400"
}
Expand Down

0 comments on commit 1350655

Please sign in to comment.