Skip to content

Commit

Permalink
fix(docker_backend): remove class DockerScyllaLogger
Browse files Browse the repository at this point in the history
this logger was filter only lines that had scylla in them
and our docker logs doesn't have the scylla compoent printed
in all of them, so we were loosing lots of the relevent log
information, we should log everything the docker output has.
  • Loading branch information
fruch committed Mar 31, 2024
1 parent ecc38a5 commit d08b301
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions sdcm/utils/remote_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,13 +275,6 @@ def __init__(self, node, target_log_file: str):
super().__init__(target_log_file)


class DockerScyllaLogger(CommandNodeLoggerBase):
# pylint: disable=invalid-overridden-method
@cached_property
def _logger_cmd(self) -> str:
return f'docker logs -f {self._node.name} 2>&1 | grep scylla >>{self._target_log_file}'


class DockerGeneralLogger(CommandNodeLoggerBase):
# pylint: disable=invalid-overridden-method
@cached_property
Expand Down Expand Up @@ -577,8 +570,6 @@ def _logger_cmd(self) -> str:

def get_system_logging_thread(logs_transport, node, target_log_file): # pylint: disable=too-many-return-statements
if logs_transport == 'docker':
if 'db-node' in node.name:
return DockerScyllaLogger(node, target_log_file)
return DockerGeneralLogger(node, target_log_file)
if logs_transport == 'kubectl':
return KubectlGeneralLogger(node, target_log_file)
Expand Down

0 comments on commit d08b301

Please sign in to comment.