fix(issue_cache): add pull-requests to cache #7850
Conversation
fruch
force-pushed
the
add_PRs_to_issue_cache_in_s3
branch
2 times, most recently
from
f1585ae to
0afb0b3
Compare
fruch
force-pushed
the
add_PRs_to_issue_cache_in_s3
branch
from
cc2d8c8 to
eca5e68
Compare
in some places we are using PRs and not issue to identify if we should be skipping something in the test code we now generate two diffrent cache files on s3 for each repository one for the issues and one for the pull requests client code is merging it to once local cache, so it's mentioning of either one should be working as expect, and read from cache, not using affecting the hourly rate-limit Ref: scylladb/qa-tasks#1735
fruch
force-pushed
the
add_PRs_to_issue_cache_in_s3
branch
from
eca5e68 to
7b0145f
Compare
|
one integration test failed: not related to this change at all |
fruch
added
backport/6.0
backport/2024.2
smells like a bug in the azure client, it's cutting some responses in half, and getting invalid jsons... |
does it reproduce often? Or this is the first case seen? |
| # TODO: Add for test, remove before merge | ||
| push: | ||
| pull_request: |
There was a problem hiding this comment.
Sounds like undesired part was merged.
There was a problem hiding this comment.
yes, I reverted it out
since for testing those github action, I open the PR from the main repo.
I did a mistake and push the changes to my fork, and merged.
anyhow I've pull back the unrelated commit from master
in some places we are using PRs and not issue to identify
if we should be skipping something in the test code
we now generate two diffrent cache files on s3 for each repository
one for the issues and one for the pull requests
client code is merging it to once local cache, so it's mentioning
of either one should be working as expect, and read from cache,
not using affecting the hourly rate-limit
Ref: https://github.com/scylladb/qa-tasks/issues/1735
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)