Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(monitoring): set the scylla monitoring image to 4.8.0 #8005

Merged
merged 5 commits into from
Aug 11, 2024
Merged

feature(monitoring): set the scylla monitoring image to 4.8.0 #8005

merged 5 commits into from
Aug 11, 2024

Conversation

amnonh
Copy link
Contributor

@amnonh amnonh commented Jul 15, 2024 •
edited by fruch
Loading

Set the monitoring image to version 4.8.0

Testing

@amnonh amnonh added the backport/none Backport is not required label Jul 15, 2024
@fruch fruch added the test-provision-aws Run provision test on AWS label Jul 17, 2024
@fruch fruch added test-provision-gce Run provision test on GCE test-provision-docker labels Jul 24, 2024
@fruch
Copy link
Contributor

fruch commented Jul 28, 2024

@amnonh

The image in AWS isn't found on eu-west-1, is those images synced across regions ?

@amnonh
Copy link
Contributor Author

amnonh commented Jul 28, 2024 •
edited
Loading

They should be, CC @yaronkaikov, who is responsible for image creation.

@yaronkaikov
Copy link
Contributor

@amnonh

The image in AWS isn't found on eu-west-1, is those images synced across regions?

It's there

image

@fruch
Copy link
Contributor

fruch commented Aug 4, 2024

@amnonh
The image in AWS isn't found on eu-west-1, is those images synced across regions?

It's there

image

@yaronkaikov, we need the Name tag, so we can find it.

@yaronkaikov
Copy link
Contributor

@amnonh
The image in AWS isn't found on eu-west-1, is those images synced across regions?

It's there
image

@yaronkaikov, we need the Name tag, so we can find it.

There is one

image

@fruch
Copy link
Contributor

fruch commented Aug 4, 2024

@amnonh
The image in AWS isn't found on eu-west-1, is those images synced across regions?

It's there
image

@yaronkaikov, we need the Name tag, so we can find it.

There is one

image

o.k. the code in SCT is looking up by name, only look in one account, and not in the images account.
that part was used for fetching other images, and not scylla images by name

@fruch
Copy link
Contributor

fruch commented Aug 4, 2024

@yaronkaikov

a PR to fix it, and lookup on both accounts, so monitor image can be found:
#8232

previously the image were clone into the main account (since they were available on all regions)
we should stop doing that..., since they now should be copied into all regions to begin with.

@amnonh
Copy link
Contributor Author

amnonh commented Aug 4, 2024

I've recreated 4.8.0 this morning, we should re-generate the images

@yaronkaikov
Copy link
Contributor

I've recreated 4.8.0 this morning, we should re-generate the images

Why re-creating? now we would have two images which are 4.8.0,

@amnonh
Copy link
Contributor Author

amnonh commented Aug 4, 2024

@yaronkaikov 4.8.0 is in RC mode, and I made changes, so I had to recreate the release, I'm not sure if images were created.

@yaronkaikov
Copy link
Contributor

@yaronkaikov 4.8.0 is in RC mode, and I made changes, so I had to recreate the release, I'm not sure if images were created.

@amnonh So let's call it (tag name) 4.8.0-rcX, and then you can increase the number for every change until it's officially out. This way QA for example can distinguish between each image by name

@amnonh
Copy link
Contributor Author

amnonh commented Aug 4, 2024

@yaronkaikov image names contain the date, I can add an rcX to the tags, if it's supported

@yaronkaikov
Copy link
Contributor

@yaronkaikov image names contain the date, I can add an rcX to the tags, if it's supported

Thanks, it should be ok, as we do in Scylla
image

@fruch fruch added backport/2023.1 Need to backport to 2023.1 backport/5.4 Need backport to 5.4 backport/2024.1 Need backport to 2024.1 backport/perf-v15 backport/2024.2 Need backport to 2024.2 backport/6.1 Need backport to 6.1 backport/6.0 backport/manager-3.3 and removed backport/none Backport is not required labels Aug 5, 2024
@fruch fruch changed the title set the scylla monitoring image to 4.8.0 feature(monitoring): set the scylla monitoring image to 4.8.0 Aug 7, 2024
@fruch
Copy link
Contributor

fruch commented Aug 7, 2024

I did: AWS: scylladb-monitor-4-8-0-2024-08-06t03-34-43z GCP: scylladb-monitor-4-8-0-2024-08-06t03-34-43z

@amnonh @yaronkaikov those images aren't working...

botocore.exceptions.ClientError: An error occurred (AuthFailure) when calling the RequestSpotInstances operation: Not authorized for images: [ami-02f241d7e29ae98ad]

meanwhile I manually setup the sharing, and raised:
scylladb/scylla-monitoring#2375

for the next time we need those images

@fruch
fix(monitoring): exclude unneed binary from monitor stack
c20448e 
code has binaries for multiple platfroms, but we don't use those
at all, and we don't need to back them up every time.
@fruch
fix(monitoring): add kiosk for automatic height calculation to work
849ac3d 
passing `height=-1` for automatic calculation of height, was broken
for a few releases, in this release it should work when `kisok` parameter
is also being passed
fruch
fruch approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 9282de2 into scylladb:master Aug 11, 2024
9 of 10 checks passed
This was referenced Aug 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@scylladbbot scylladbbot added backport/6.1-done Commit backported to 6.1 backport/2024.2-done Commit backported to 2024.2 backport/perf-v15-done backport/3.3-done and removed backport/6.1 Need backport to 6.1 backport/2024.2 Need backport to 2024.2 backport/perf-v15 labels Aug 12, 2024
@mikliapko
Copy link
Contributor

@amnonh @fruch
I suppose this fix broke some Manager tests:

13:01:34  ----- LAST ERROR EVENT -------------------------------------------------------
13:01:34  2024-08-13 11:01:20.621: (TestFrameworkEvent Severity.ERROR) period_type=one-time event_id=8e220cb6-4ea4-4484-9223-5099475f54c2, source=MgmtCliTest.SetUp()
13:01:34  exception=An error occurred (AuthFailure) when calling the RequestSpotInstances operation: Not authorized for images: [ami-0b02bf09acc3d3292]

https://jenkins.scylladb.com/view/scylla-manager/job/manager-master/job/ubuntu22-installation-test/2/

@fruch
Copy link
Contributor

fruch commented Aug 13, 2024

@amnonh @fruch
I suppose this fix broke some Manager tests:

13:01:34  ----- LAST ERROR EVENT -------------------------------------------------------
13:01:34  2024-08-13 11:01:20.621: (TestFrameworkEvent Severity.ERROR) period_type=one-time event_id=8e220cb6-4ea4-4484-9223-5099475f54c2, source=MgmtCliTest.SetUp()
13:01:34  exception=An error occurred (AuthFailure) when calling the RequestSpotInstances operation: Not authorized for images: [ami-0b02bf09acc3d3292]

https://jenkins.scylladb.com/view/scylla-manager/job/manager-master/job/ubuntu22-installation-test/2/

In which region is this running?

I can guess I've missed some AMI, setting the sharing information

Until scylladb/scylla-monitoring#2375
Would be fixed

@mikliapko
Copy link
Contributor

@amnonh @fruch
I suppose this fix broke some Manager tests:

13:01:34  ----- LAST ERROR EVENT -------------------------------------------------------
13:01:34  2024-08-13 11:01:20.621: (TestFrameworkEvent Severity.ERROR) period_type=one-time event_id=8e220cb6-4ea4-4484-9223-5099475f54c2, source=MgmtCliTest.SetUp()
13:01:34  exception=An error occurred (AuthFailure) when calling the RequestSpotInstances operation: Not authorized for images: [ami-0b02bf09acc3d3292]

https://jenkins.scylladb.com/view/scylla-manager/job/manager-master/job/ubuntu22-installation-test/2/

In which region is this running?

I can guess I've missed some AMI, setting the sharing information

Until scylladb/scylla-monitoring#2375 Would be fixed

It's us-east-1 region

@fruch
Copy link
Contributor

fruch commented Aug 13, 2024

@amnonh @fruch
I suppose this fix broke some Manager tests:

13:01:34  ----- LAST ERROR EVENT -------------------------------------------------------
13:01:34  2024-08-13 11:01:20.621: (TestFrameworkEvent Severity.ERROR) period_type=one-time event_id=8e220cb6-4ea4-4484-9223-5099475f54c2, source=MgmtCliTest.SetUp()
13:01:34  exception=An error occurred (AuthFailure) when calling the RequestSpotInstances operation: Not authorized for images: [ami-0b02bf09acc3d3292]

https://jenkins.scylladb.com/view/scylla-manager/job/manager-master/job/ubuntu22-installation-test/2/

In which region is this running?
I can guess I've missed some AMI, setting the sharing information
Until scylladb/scylla-monitoring#2375 Would be fixed

It's us-east-1 region

Fix the permissions, and re-run that job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruch fruch fruch approved these changes

Assignees

@amnonh amnonh

Labels
backport/manager-3.3 backport/perf-v15-done backport/3.3-done backport/5.4 Need backport to 5.4 backport/6.0 backport/6.1-done Commit backported to 6.1 backport/2023.1 Need to backport to 2023.1 backport/2024.1 Need backport to 2024.1 backport/2024.2-done Commit backported to 2024.2 promoted-to-master test-provision-aws Run provision test on AWS test-provision-docker test-provision-gce Run provision test on GCE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amnonh @fruch @yaronkaikov @mikliapko @scylladbbot