Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_exporter: upgrade to v1.8.2, remove unneeded collectors #9621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mykaul
Copy link
Contributor

@mykaul mykaul commented Dec 26, 2024

This PR update node_exporter to v1.8.2 (just like Scylla) and removes the unneeded collectors that are enabled by default (just like Scylla). The only exception is interrupts - which are still enabled by default by Scylla and are not needed here.

Testing

  • NOT tested.

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

This PR update node_exporter to v1.8.2 (just like Scylla) and removes the unneeded collectors that are enabled by default (just like Scylla).
The only execption is interrupts - which are still enabled by default by Scylla and are not needed here.

Signed-off-by: Yaniv Kaul <[email protected]>
@mykaul mykaul added the backport/none Backport is not required label Dec 26, 2024
@mykaul
Copy link
Contributor Author

mykaul commented Dec 26, 2024

Unsure why CI failed:
image

@soyacz
Copy link
Contributor

soyacz commented Dec 27, 2024

it failed on precommit (visible in GH checks), more specifically commit lint. We follow a structured tilte: <feature | fix | improvement>(<area>): <message> and commit message must be long enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants