Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 6.2] fix(bucket-locations): add templating to backup_bucket_location #9807

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

scylladbbot
Copy link

since now we are doing backup/restore in the test region and backup_bucket_region was remove.

the code for this configuration need to be templated as it was done for restore nemesis

otherwise we fail like the following:

23:22:43  Command: 'sudo sctool backup -c a05d9ea2-312c-4c8d-99b0-9f9b57e8cbde
          --keyspace scylla_bench,keyspace1  --location s3:manager-backup-tests-us-east-1 '
23:22:43  Exit code: 1
23:22:43  Stdout:
23:22:43  Stderr:
23:22:43  Error: create backup target: location is not accessible
23:22:43  10.4.2.70: agent [HTTP 400] operation put: s3 upload: 301 Moved Permanently:
          The bucket you are attempting to access must be addressed using the specified endpoint.
          Please send all future requests to this endpoint. (code:PermanentRedirect) - make sure the location
          is correct and credentials are set, to debug SSH to 10.4.2.70 and run
          "scylla-manager-agent check-location -L s3:manager-backup-tests-us-east-1 --debug"
23:22:43  Trace ID: DXvyKGPjQMKUCkJpyxlKCQ (grep in scylla-manager logs)

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)

  • Add unit tests to cover my changes (under unit-test/ folder)

  • Update the Readme/doc folder relevant to this change (if needed)

  • (cherry picked from commit fe55645)

Parent PR: #9788

@scylladbbot
Copy link
Author

@fruch - This PR has conflicts, therefore it was moved to draft
Please resolve them and mark this PR as ready for review

since now we are doing backup/restore in the test region
and `backup_bucket_region` was remove.

the code for this configuration need to be templated as it was done
for restore nemesis

otherwise we fail like the following:
```
23:22:43  Command: 'sudo sctool backup -c a05d9ea2-312c-4c8d-99b0-9f9b57e8cbde
          --keyspace scylla_bench,keyspace1  --location s3:manager-backup-tests-us-east-1 '
23:22:43  Exit code: 1
23:22:43  Stdout:
23:22:43  Stderr:
23:22:43  Error: create backup target: location is not accessible
23:22:43  10.4.2.70: agent [HTTP 400] operation put: s3 upload: 301 Moved Permanently:
          The bucket you are attempting to access must be addressed using the specified endpoint.
          Please send all future requests to this endpoint. (code:PermanentRedirect) - make sure the location
          is correct and credentials are set, to debug SSH to 10.4.2.70 and run
          "scylla-manager-agent check-location -L s3:manager-backup-tests-us-east-1 --debug"
23:22:43  Trace ID: DXvyKGPjQMKUCkJpyxlKCQ (grep in scylla-manager logs)
```

(cherry picked from commit fe55645)
@fruch fruch force-pushed the backport/9788/to-6.2 branch from 19b2fab to 2a1e99f Compare January 14, 2025 08:17
@fruch fruch removed the conflicts label Jan 14, 2025
@fruch fruch marked this pull request as ready for review January 14, 2025 08:17
@fruch fruch merged commit 4be7457 into scylladb:branch-6.2 Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants