-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tablet repair #3725
Tablet repair #3725
Conversation
This approach stores only a single ring description at a time (instead of all of them) and makes it easier to move to per table ring descriptions.
Ref #16509 (in scylladb)
This allows for checking which keyspaces have vnodes/tablets replication.
It allows for easy and efficient ring describing which works with older Scylla versions and tablet and vnode tables.
I encountered:
when running repair against |
CC @asias |
|
@Michal-Leszczynski I saw you closed the PR. Are the relevant patches merged already? Btw, you can start to test SM with the latest branch scylladb/scylladb#17767. It contains all the necessary options support for SM. |
This PR was closed because it was rebased on other repair related PR that was laying ground work for tablet repair and it got heavily refactored. I will get what's useful from this PR and test SM repair on tablets table today. |
@asias I see that the host param is not suported. SM repair uses the host param in order to filter dcs and down nodes. It can be changed to use the dc param for dc filtering, but what about filtering out down nodes? |
We will have hosts and ignore_nodes option support (PR is not merged in master). As I mentioned above: #3725 (comment) See here: scylladb/scylladb#17767. |
WIP - have yet to test it against Scylla with tablets enabled.