Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tablet repair #3725

Closed
wants to merge 7 commits into from
Closed

Tablet repair #3725

wants to merge 7 commits into from

Conversation

Michal-Leszczynski
Copy link
Collaborator

WIP - have yet to test it against Scylla with tablets enabled.

This approach stores only a single ring description at a time (instead of all of them) and makes it easier to move to per table ring descriptions.
This allows for checking which keyspaces have vnodes/tablets replication.
It allows for easy and efficient ring describing which works with older Scylla versions and tablet and vnode tables.
@Michal-Leszczynski
Copy link
Collaborator Author

I encountered:

agent [HTTP 500] std::runtime_error (The ranges option is not supported for tablet repair)"

when running repair against scylla-nightly:latest.

@mykaul
Copy link
Contributor

mykaul commented Mar 3, 2024

CC @asias

@asias
Copy link

asias commented Mar 4, 2024

I encountered:

agent [HTTP 500] std::runtime_error (The ranges option is not supported for tablet repair)"

when running repair against scylla-nightly:latest.

scylladb/scylladb#17436
scylladb/scylladb#17571

@asias
Copy link

asias commented Mar 13, 2024

@Michal-Leszczynski I saw you closed the PR. Are the relevant patches merged already? Btw, you can start to test SM with the latest branch scylladb/scylladb#17767. It contains all the necessary options support for SM.

@Michal-Leszczynski
Copy link
Collaborator Author

This PR was closed because it was rebased on other repair related PR that was laying ground work for tablet repair and it got heavily refactored. I will get what's useful from this PR and test SM repair on tablets table today.

@Michal-Leszczynski
Copy link
Collaborator Author

@asias I see that the host param is not suported. SM repair uses the host param in order to filter dcs and down nodes. It can be changed to use the dc param for dc filtering, but what about filtering out down nodes?

@asias
Copy link

asias commented Mar 14, 2024

@asias I see that the host param is not suported. SM repair uses the host param in order to filter dcs and down nodes. It can be changed to use the dc param for dc filtering, but what about filtering out down nodes?

We will have hosts and ignore_nodes option support (PR is not merged in master). As I mentioned above: #3725 (comment)

See here: scylladb/scylladb#17767.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants