Don't backup views#3918
Merged
Michal-Leszczynski merged 6 commits intomasterfrom Jul 23, 2024
Merged
Conversation
Michal-Leszczynski
force-pushed
the
ml/dont-backup-views
branch
3 times, most recently
from
e604db5 to
a6eeaf5
Compare
Collaborator
Author
|
@annastuchlik could you review the last commit related to docs ( |
Collaborator
karol-kokoszka
left a comment
karol-kokoszka
left a comment
There was a problem hiding this comment.
I encourage you to do bit bigger refactor of GetTarget, please check the comment and let me know WDYT or if you have some other idea that can make this part more intuitive.
Michal-Leszczynski
added a commit
that referenced
this pull request
Jul 11, 2024
Michal-Leszczynski
force-pushed
the
ml/dont-backup-views
branch
from
a6eeaf5 to
ba64046
Compare
This way there is no need for storing all ring descriptions in a map relatively big map. Moreover, it skips querying ring description for tables that are going to be filtered out anyway. It also allows for further refactor.
… dedicated methods
Michal-Leszczynski
force-pushed
the
ml/dont-backup-views
branch
from
ba64046 to
68c6f5f
Compare
Collaborator
|
@Michal-Leszczynski it's a draft PR, I understand it's still in progress ? |
Collaborator
Author
|
@karol-kokoszka now it's ready for review! |
karol-kokoszka
approved these changes
Jul 17, 2024
Collaborator
karol-kokoszka
left a comment
karol-kokoszka
left a comment
There was a problem hiding this comment.
Very nice !
Thank you for the effort.
👍 but please consider two additional comments I left.
Michal-Leszczynski
force-pushed
the
ml/dont-backup-views
branch
from
68c6f5f to
a8743d5
Compare
karol-kokoszka
approved these changes
Jul 23, 2024
This is to emphasise that even though the REST API interface method is called GetTarget, the actual implementation is not a simple getter.
Collaborator
Author
|
@annastuchlik could you take a look at a8743d5? |
Michal-Leszczynski
added a commit
that referenced
this pull request
Jul 23, 2024
karol-kokoszka
pushed a commit
that referenced
this pull request
Aug 9, 2024
Merged
karol-kokoszka
pushed a commit
that referenced
this pull request
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3771