Label tasks and clusters #3934
Merged
Label tasks and clusters #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove deprecated tags field.
|
@karol-kokoszka This PR is ready for review! @annastuchlik could you take a look just at the last commit |
karol-kokoszka
approved these changes
Jul 22, 2024
It allows for specifying label diff that should be used for labeling clusters/tasks. It's important that sctool users are required to pass only the label diff, so that they don't overwrite labels used by other users or operator.
So that all tasks can use the --label flag.
So that labels are visible in the output of 'sctool tasks'.
So that labels are visible in the output of 'sctool info'.
Michal-Leszczynski
force-pushed
the
ml/task-and-cluster-labels
branch
from
a693d7d to
ba52cd5
Compare
So that labels are visible in the output of 'sctool cluster list'.
Michal-Leszczynski
force-pushed
the
ml/task-and-cluster-labels
branch
from
ba52cd5 to
dc9ce85
Compare
|
@karol-kokoszka This PR is ready for re-review! |
|
@Michal-Leszczynski Thanks! Good to go. It's approved already. |
|
@annastuchlik could you take a look at dc9ce85? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a possibility of labeling cluster/tasks with the
--labelflag.I decided to implement the approach with a single flag, which has the special syntax for defining labels to be removed (similar to the kubctl label).
Fixes #3219