Don't blacklist restored tables#4021
Merged
Michal-Leszczynski merged 2 commits intomasterfrom Sep 17, 2024
Merged
Conversation
Michal-Leszczynski
force-pushed
the
ml/fix-3998
branch
2 times, most recently
from
a6b0209 to
129a4e8
Compare
Collaborator
Author
|
@karol-kokoszka this PR is ready for review! |
karol-kokoszka
approved these changes
Sep 17, 2024
This approach was error-prone and difficult to test (e.g. Scylla cluster might have some leftover cdc tables from previous releases that are not present in the fresh clusters). It also allows for a more unified mechanism of excluding raft managed tables (replicated locally) from being restored. Fixes #3998
Michal-Leszczynski
force-pushed
the
ml/fix-3998
branch
from
129a4e8 to
bbd42cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blacklisting approach was error-prone and difficult to test (e.g. Scylla cluster might have some leftover cdc tables from previous releases that are not present in the fresh clusters).
It also allows for a more unified mechanism of excluding raft managed tables (replicated locally) from being restored.
Rebased on #4034.
Fixes #3998