tablet repair API filtering#4301
Merged
Michal-Leszczynski merged 15 commits intomasterfrom Mar 25, 2025
Merged
Conversation
Michal-Leszczynski
force-pushed
the
ml/tablet-repair-api-filtering
branch
4 times, most recently
from
3df9b75 to
3c5e40e
Compare
This reverts commit 76b118d.
Scylla 2025.1.0 is introducing new tablet repair API. SM should use it for repairing tablet tables with a single API call. Fixes #4188
Scylla 2025.1.0 is introducing new tablet repair API which does not require stopping tablet load balancing during the repair. Fixes #4273
SM repair task supports 3 types of host filtering: * --dc - controlled by API dc filter * --ignore-down-nodes - controlled by API host filter * --host - does not make sense for tablet table This commit adds validation for --ignores-down-nodes and --host configurations. Fixes #4292
This might result in hiding some issues, so we better use it only when it's directly specified by the test.
Michal-Leszczynski
force-pushed
the
ml/tablet-repair-api-filtering
branch
from
3c5e40e to
d8091ca
Compare
Michal-Leszczynski
requested review from
VAveryanov8 and
karol-kokoszka
as code owners
VAveryanov8
approved these changes
Mar 19, 2025
Collaborator
Author
|
@karol-kokoszka This PR is ready for review! |
This commit fixes a bug discovered by: #4301 (comment) SM was handling tablet load balancing for repair completely wrong for cluster with both vnode and tablet keyspaces. In such cases, it was enabling tablet load balancing when repairing tablet keyspaces, and disabling it when it was repairing vnode keyspaces.
Collaborator
Author
|
@VAveryanov8 could you take one more look at this PR? I added two commits since your review. |
VAveryanov8
reviewed
Mar 25, 2025
Collaborator
|
Looks good to me 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts SM repair procedure to use tablet repair API filtering for Scylla 2025.1.0.
This means that we don't stop tablet load balancing when repairing tablet keyspaces during repair with Scylla 2025.1.0.
We still follow the same workflow as with the old repair API optimizations (we create per replica-set 'dummy' jobs just for progress which is still reported in ranges count).
Until #4303 is fixed, we test tablet repair API behavior with Scylla
scylladb-ci:2025.2.0-dev-0.20250310.8d676048a6d9, which contains tablet repair API filtering feature, but is not yet based on the ubi minimal image.Fixes #4188
Fixes #4273
Fixes #4292