Make some configuration properties optional #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `rename`: default to the empty list if not set - `skipTokenRanges`: default to the empty set if not set - `validation`: make it mandatory only when we run the Validator (but not the Migrator) Fixes scylladb#164
julienrf
force-pushed
the
optional-config-properties
branch
from
e79a02c to
170f4cb
Compare
|
nice, thank you, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename: default to the empty list if not setskipTokenRanges: default to the empty set if not setvalidation: make it mandatory only when we run the Validator (but not the Migrator)Note that
savepointswas not made optional because I am expecting savepoints to be supported soon for DynamoDB migrations as well.Fixes #164