Remove our custom credentials provider #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would expect any regression here to be caught by the streaming test, which relies on the profile credentials. So, we need to run the “tests-aws” workflow on this PR before we merge it. |
It is not needed now that `emr-dynamodb-connector` defaults to the same credentials provider (see awslabs/emr-dynamodb-connector#203 and scylladb/emr-dynamodb-connector#9).
julienrf
force-pushed
the
remove-custom-credentials-provider
branch
from
e897085 to
599fef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not needed now that
emr-dynamodb-connectordefaults to the same credentials provider (see awslabs/emr-dynamodb-connector#203 and scylladb/emr-dynamodb-connector#9).