Add an e2e test for retryable NodeConfig mount units #2253
Conversation
scylla-operator-bot
bot
added
do-not-merge/work-in-progress
|
@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik. Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
scylla-operator-bot
bot
added
priority/important-longterm
rzetelskik
force-pushed
the
retry-mounts
branch
4 times, most recently
from
23d1880 to
752ef07
Compare
rzetelskik
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
rzetelskik
force-pushed
the
retry-mounts
branch
from
752ef07 to
51e7c47
Compare
rzetelskik
changed the title
scylla-operator-bot
bot
added
the
do-not-merge/work-in-progress
rzetelskik
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
|
/cc zimnx tnozicka |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scylla-operator-bot
bot
added
the
approved
Description of your changes: It seems that the scenario described in #1559 has been covered by #2134. I wasn't able to find a scenario that would differentiate the case where a mount unit would require a restart to end up in an active state (as opposed to just starting it again as we do now), so this PR only adds an e2e covering the scenario described in the issue. We can go back to discussing the restarts if an actual scenario comes up.
Which issue is resolved by this Pull Request:
Resolves #1559
/kind feature
/priority important-longterm
/cc