Skip to content

Commit

Permalink
build: s/Sanitizers_COMPILER_OPTIONS/Sanitizers_COMPILE_OPTIONS
Browse files Browse the repository at this point in the history
this change addresses a regression introduced by ed88919, which
renamed the exported CMake variable of `Sanitizers_COMPILER_OPTIONS`
to `Sanitizers_COMPILE_OPTIONS`, to be more consistent with the
names used by CMake. but it failed to update the top-level
`CMakeLists.txt`, which was still using the old name to populate
this setting down to .pc. that's why some parent project fails to
link with the latest seastar with sanitizers enabled.

in this change, we correct the variable name.

Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov authored and avikivity committed Sep 17, 2024
1 parent ebb0385 commit 69f88e2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,7 @@ if (condition)
if (NOT Sanitizers_FOUND)
message (FATAL_ERROR "Sanitizers not found!")
endif ()
set (Seastar_Sanitizers_OPTIONS ${Sanitizers_COMPILER_OPTIONS})
set (Seastar_Sanitizers_OPTIONS ${Sanitizers_COMPILE_OPTIONS})
target_link_libraries (seastar
PUBLIC
$<${condition}:Sanitizers::address>
Expand Down

0 comments on commit 69f88e2

Please sign in to comment.