Skip to content

Commit

Permalink
build: drop the workaround for a GCC bug
Browse files Browse the repository at this point in the history
this change partially reverts 87a6540, which workarounded a bug
in GCC-10 and LLVM-3.8, see
https://gcc.gnu.org/git/?p=gcc.git&a=commit;h=1842a04ce06a470b731bc9a29bfec17e6e147c3f
and
llvm/llvm-project@894d582
respectively.

since scylla builds with GCC-13 and GCC-14, LLVM-17 and LLVM-18.
so we don't need to keep this workaround anymore.

Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov authored and avikivity committed Sep 23, 2024
1 parent e9915cc commit a8b2588
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions cmake/FindSanitizers.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ foreach (component ${Sanitizers_FIND_COMPONENTS})
list (APPEND ${compile_options} -fsanitize=address)
elseif (component STREQUAL "undefined_behavior")
list (APPEND ${compile_options} -fsanitize=undefined)
# Disable vptr because of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684
list (APPEND ${compile_options} -fno-sanitize=vptr)
else ()
message (FATAL_ERROR "Unsupported sanitizer: ${component}")
endif ()
Expand Down

0 comments on commit a8b2588

Please sign in to comment.