Skip to content

Commit

Permalink
github: add a step to build "check-include-style"
Browse files Browse the repository at this point in the history
Previously, we do not enforce the policy of including Seastar headers
using angle brackets instead of double quotes in our github workflow.
In this change, a new step is added to build "check-include-style"
target when building the Dev mode. This allows our CI to fail if a
change violates this policy.

Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov committed Dec 22, 2024
1 parent 32a331b commit ad6be0f
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ jobs:
if: ${{ inputs.mode == 'dev' && inputs.compiler == 'clang++' }}
run: cmake --build build/${{ inputs.mode }} --target checkheaders

- name: Check Include Style
if: ${{ inputs.mode == 'dev' && inputs.compiler == 'clang++' }}
run: cmake --build build/${{ inputs.mode }} --target check-include-style

- name: Build with C++20 modules
if: ${{ contains(inputs.enables, 'cxx-modules') }}
run: cmake --build build/${{ inputs.mode }} --target hello_cxx_module
Expand Down

0 comments on commit ad6be0f

Please sign in to comment.