build: check for P2582R1 support #2446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
CTAD-inherited-ctor
branch
4 times, most recently
from
bfc21f2 to
f32644d
Compare
in a recent GCC packaging update in fedora, the maintainer backported a patch [PR116276](https://gcc.gnu.org/pipermail/gcc-patches/2024-August/659909.html) from GCC-14. the patch implements [P2582R1 - Wording for class template argument deduction from inherited constructors](https://wg21.link/P2582R1) which was accepted by C++23. since it's included by C++23, Clang is also working in this direction, see llvm/llvm-project#92606. this is the reason why gcc-14.2.1-3 fails to build the tree, which relies on the behavior without P2582R1. in this change, we check for the support of P2581R1 with CMake, and defined `SEASTAR_P2581R1` macro if the proposed behavior is implemented. we define the argument deduction guide for `rpc::tuple` only if this macro is not defined. this should address the build failure. and it is future-proof as once Clang supports P2581R1, we can detect it, and disable the dedution guide as well. Fixes scylladb#2445 Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
CTAD-inherited-ctor
branch
from
f32644d to
3888ebc
Compare
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a recent GCC packaging update in fedora, the maintainer backported a patch PR116276 from GCC-14. the patch implements
P2582R1 - Wording for class template argument deduction from inherited constructors which was accepted by C++23. since it's included by C++23, Clang is also working in this direction, see
llvm/llvm-project#92606.
this is the reason why gcc-14.2.1-3 fails to build the tree, which relies on the behavior without P2582R1.
in this change, we check for the support of P2581R1 with CMake, and define
SEASTAR_P2581R1macro if the proposed behavior is implemented. we define the argument deduction guide forrpc::tupleonly if this macro is not defined. this should address the build failure. and it is future-proof as once Clang supports P2581R1, we can detect it, and disable the dedution guide as well.Fixes #2445
Signed-off-by: Kefu Chai [email protected]