Misc compile include/warn fixes #2448
Closed
+26
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No system headers included if SEASTAR_MODULES was undefined, fix it to the usual pattern.
tchaikov
approved these changes
Sep 21, 2024
Yes, thanks for the note. I don't think any of the changes here involve a location that would be a performance concern for |
Fix a few unused result warnings that have popped up in gcc. In some cases this involves actually checking the return type, mostly for write(event_fd,...) and in this case it seems that we never expect any type of failure here (non-zero return code would only be on eventfd wrap if fd is in blocking mode, invalid arguments).
travisdowns
force-pushed
the
td-misc-warn-fixes
branch
from
745d361 to
188baf1
Compare
ahh, thought that the |
|
@scylladb/seastar-maint hello maintainers, could you help review/merge this change? |
1 similar comment
|
@scylladb/seastar-maint hello maintainers, could you help review/merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong includes related to SEASTAR_MODULE
Fix "unused result" warnings in gcc
Tests all pass, see changes for details.