Expose some HTTP functionality useful for websocket code #2579
+77
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Websocket protocol handshake uses HTTP, thus it makes sense to reuse at least some of the abstractions and API style.
Websocket client connection starts by a plain HTTP request with some websocket-specific headers. Due to this similarity it makes sense to reuse existing HTTP code when implementing websocket client in the future. For that at least request_line() and write_request_headers() are required. These functions are accessible to existing HTTP client code due to friend class experimental::connection being present.
|
@xemul Just a friendly ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes some HTTP functionality that will useful for websocket code. The PR essentially takes two commits from #2552 so that it's easier to review and land the PR.