Add http2 support. Start with http2 frame parsing logic #2886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muthu90tech
commented
Jul 30, 2025
| */ | ||
|
|
||
|
|
||
| #define SEASTAR_HTTP2_TEST |
There was a problem hiding this comment.
Would like a better way to expose private functions for test purposes.
muthu90tech
force-pushed
the
http2_support
branch
from
a2de6d5 to
fffba74
Compare
muthu90tech
force-pushed
the
http2_support
branch
from
fffba74 to
e8ec254
Compare
xemul
reviewed
Sep 18, 2025
|
|
||
| namespace http { | ||
|
|
||
| class http2_connection { |
There was a problem hiding this comment.
This du[licates (at the first glance) the client.hh conneciton class
xemul
reviewed
Sep 18, 2025
| // Main entry point to start processing the HTTP/2 connection. | ||
| future<> process(); | ||
|
|
||
| #ifdef SEASTAR_HTTP2_TEST |
There was a problem hiding this comment.
We try to avoid ifdefs for no special readons. If the intent is just to get a private field out of a class, declare a method in internal or testing namespace that's friend to that class
|
We have both -- http server and client implementation in seastar. Does support for http2 come for both as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to work on the http2 support in seastar, mentioned here
Since this is a large task, I want to start small get feedback and iterate. Eventually making it compliant with http2 spec