io: Count and export number of AIO retries #2975
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avikivity
reviewed
Sep 11, 2025
The AIO requests may come via two places -- the reactor itself polling for IO and thread-pool that retries requests that had been rejected by the kernel on the first try. This patch counts the latter events and exports them as metrics. The former can be calculated using existing aio-reads and aio-writes. Signed-off-by: Pavel Emelyanov <[email protected]>
xemul
force-pushed
the
br-reactor-io-submit-resubmit-metrics
branch
from
66f7e18 to
8bf7ba2
Compare
Contributor
Author
|
upd:
|
xemul
changed the title
Contributor
Author
|
@avikivity , please re-review |
Contributor
Author
|
@avikivity , please re-review |
Contributor
|
This patch would be very nice! |
Contributor
Author
|
@avikivity , please re-review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AIO requests may come via two places -- the reactor itself polling
for IO and thread-pool that retries requests that had been rejected by
the kernel on the first try.
This patch counts the latter events and exports them as metrics. The
former can be calculated using existing aio-reads and aio-writes.