futurize::invoke: use std::invoke and forwarding #3019
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use std::invoke to call the passed function, rather than a direct call. This allows member function pointers and other callable types to be used. This is already the case in other calls like future_invoke. - Forward the function itself, not just the arguments. This allows an rvalue-qualified operator() to be called if present. This is good for a 0.06% reduction in the .text section of the release redpanda binary, so I guess we do have some && call operators? The real reason for this though is the std::invoke part. Later I build on this.
avikivity
reviewed
Oct 3, 2025
|
|
||
| template<typename T> | ||
| template<typename Func, typename... FuncArgs> | ||
| typename futurize<T>::type futurize<T>::invoke(Func&& func, FuncArgs&&... args) noexcept { |
There was a problem hiding this comment.
- Forward the function itself, not just the arguments. This allows
an rvalue-qualified operator() to be called if present.
950b54e beat you to it, so now you get to rebase and I get to re-run CI
There was a problem hiding this comment.
Yeah haha, weird how it was like that for 8 years or whatever then suddenly two very similar changes collide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is good for a 0.06% reduction in the .text section of the release redpanda binary, so I guess we do have some && call operators?
The real reason for this though is the std::invoke part. Later I build on this.